fix: Final-Review-Findings (GUI-Login, FK-Kaskaden, Validierung, Duplikat-Recheck, Views)
F1: GUI-Login-Hash gegen $-Korruption gehaertet. .env-Werte einfach-gequotet
geschrieben + Sanity-Check nach Sourcing. Zusaetzlich systemd-Ebene:
podman escapt $->$$ in Environment=, systemd 252 kollabiert das nicht ->
sed-Post-Processing der Unit-Dateien. Live-.env: GUI-Passwort rotiert.
F2: Explizite Dependent-Deletes gegen FK-500 (delete_scenario/loan), 409 bei
bestaetigtem Import-Delete. Test-Engine erzwingt PRAGMA foreign_keys=ON.
F3: Enum/Range-Validierung (Literal + Field ge/le) fuer Recurring, Loan,
Modifier inkl. PATCH-Pfade.
F4: Confirm nur fuer draft-Statements (sonst 409) + Dedup-Re-Check gegen
bestaetigte Buchungen vor dem Promoten.
F5: v_balance_history/v_balance_total addieren pro Konto den opening_balance
des fruehesten bestaetigten Statements (approved deviation vom Plan-SQL).
F6: patch_scenario Namenskollision -> 409; create_transaction unbekanntes
Konto -> 404 (statt 500).
F7: Generierte systemd-Unit-Dateien chmod 600 (enthalten Env-Secrets).
F8: Globaler htmx:responseError-Handler in base.html.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -115,6 +115,8 @@ def confirm(statement_id: int, session: Session = Depends(get_session)):
|
||||
stmt = session.get(Statement, statement_id)
|
||||
if stmt is None:
|
||||
raise HTTPException(404, "Import nicht gefunden")
|
||||
if stmt.status != "draft":
|
||||
raise HTTPException(409, "Import ist nicht im Entwurfsstatus")
|
||||
txs = session.execute(
|
||||
select(Transaction).where(
|
||||
Transaction.statement_id == statement_id,
|
||||
@@ -123,6 +125,19 @@ def confirm(statement_id: int, session: Session = Depends(get_session)):
|
||||
)
|
||||
).scalars().all()
|
||||
for tx in txs:
|
||||
# Re-check against currently confirmed transactions: another import
|
||||
# confirmed between preview and now may have introduced the same
|
||||
# booking. Mark late duplicates and skip promoting them.
|
||||
clash = session.execute(
|
||||
select(Transaction).where(
|
||||
Transaction.dedup_hash == tx.dedup_hash,
|
||||
Transaction.status == "confirmed",
|
||||
Transaction.id != tx.id,
|
||||
)
|
||||
).scalar()
|
||||
if clash is not None:
|
||||
tx.is_duplicate = True
|
||||
continue
|
||||
tx.status = "confirmed"
|
||||
stmt.status = "confirmed"
|
||||
session.commit()
|
||||
@@ -135,6 +150,8 @@ def delete_import(statement_id: int, session: Session = Depends(get_session)):
|
||||
stmt = session.get(Statement, statement_id)
|
||||
if stmt is None:
|
||||
raise HTTPException(404, "Import nicht gefunden")
|
||||
if stmt.status == "confirmed":
|
||||
raise HTTPException(409, "Bestätigter Import kann nicht gelöscht werden")
|
||||
drafts = session.execute(
|
||||
select(Transaction).where(
|
||||
Transaction.statement_id == statement_id,
|
||||
|
||||
Reference in New Issue
Block a user